-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Nested RequestHandlers #415
DOC Nested RequestHandlers #415
Conversation
fd73a77
to
01a26a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first review is just about the markdown linting - all of the failures were valid. Here's how you should resolve them:
00cb8ad
to
5cba9fc
Compare
@GuySartorelli Have updated. I really dislike the php namespace requirements linting, I don't want to add an empty namespace to the code examples because its unnecessary and will indent the examples. While I could add an arbitary namespace it might not match what someones project has. Can we simply disable that rule in the linter? |
Do not use empty namespaces, unless the example explicitly is for the For everything else, a real namespace should be used (e.g.
These are examples, which show best practice. People can use whatever namespace they want. They don't have to match the examples. They might name the classes or methods something else too - but we still have class names and method names in examples. I still see people not using namespaces in their projects, and part of the reason seems to be that almost none of our examples have had namespaces until very recently. Documentation that shows best practice is more likely to lead to people using best practice in their own projects. |
f61fd88
to
7481d4b
Compare
7481d4b
to
979cbd5
Compare
Please rebase so the php linting passes |
979cbd5
to
78e5322
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #401
Linting errors appear invalid, seem like linter rules need to be relaxed