Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Document using GridField with arbitrary data #409

Merged
merged 2 commits into from
Dec 21, 2023
Merged

DOC Document using GridField with arbitrary data #409

merged 2 commits into from
Dec 21, 2023

Conversation

GuySartorelli
Copy link
Member

GuySartorelli
GuySartorelli commented Nov 30, 2023
View reviewed changes
Copy link
Member Author

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The branch this PR is targetting now has a CI action. This PR will need to be force-pushed to run the CI, and the CI must be green before merging.

@GuySartorelli GuySartorelli force-pushed the pulls/5/arbitrary-gridfield-data branch from 5d05776 to 1f29cda Compare November 30, 2023 06:19
@GuySartorelli
Copy link
Member Author

Rebased and resolved conflicts, lint passes locally.

@GuySartorelli GuySartorelli mentioned this pull request Dec 10, 2023
Closed
3 tasks
@GuySartorelli GuySartorelli force-pushed the pulls/5/arbitrary-gridfield-data branch 2 times, most recently from 87019cf to 9f237d6 Compare December 10, 2023 23:47
maxime-rainville
maxime-rainville requested changes Dec 17, 2023
View reviewed changes
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/07_Using_GridField_With_Arbitrary_Data.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/Field_types/04_GridField.md Outdated Show resolved Hide resolved
en/04_Changelogs/5.2.0.md Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli force-pushed the pulls/5/arbitrary-gridfield-data branch from 9f237d6 to 99609e7 Compare December 17, 2023 21:05
maxime-rainville
maxime-rainville requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some extra comments not overly fuss about any of them.

@GuySartorelli GuySartorelli force-pushed the pulls/5/arbitrary-gridfield-data branch 2 times, most recently from 306d5bd to deb7f1b Compare December 19, 2023 22:37
@GuySartorelli GuySartorelli force-pushed the pulls/5/arbitrary-gridfield-data branch from deb7f1b to 3657480 Compare December 20, 2023 01:46
maxime-rainville
maxime-rainville approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me happy

@maxime-rainville maxime-rainville merged commit 7cf3a9b into silverstripe:5 Dec 21, 2023
3 checks passed
@maxime-rainville maxime-rainville deleted the pulls/5/arbitrary-gridfield-data branch December 21, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @maxime-rainville