Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Add new query trace comment to changelog #404

Merged
merged 1 commit into from
Feb 8, 2024
Merged

DOC Add new query trace comment to changelog #404

merged 1 commit into from
Feb 8, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Nov 22, 2023
Closed
GuySartorelli
GuySartorelli commented Nov 30, 2023
View reviewed changes
Copy link
Member Author

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The branch this PR is targetting now has a CI action. This PR will need to be force-pushed to run the CI, and the CI must be green before merging.

@GuySartorelli
Copy link
Member Author

Rebased and resolved conflicts, lint passes locally.

@GuySartorelli
Copy link
Member Author

Rebased and resolved conflicts

@GuySartorelli
Copy link
Member Author

Docs updated to reflect changes in the code

emteknetnz
emteknetnz requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the main PR I recommended adding enabling via an environment variable, so that should also be documented here

@GuySartorelli
Copy link
Member Author

Updated to reference new environment variable

@emteknetnz emteknetnz merged commit fee67b6 into silverstripe:5 Feb 8, 2024
3 checks passed
@emteknetnz emteknetnz deleted the pulls/5/trace-queries branch February 8, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz