-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Document new community roles #394
DOC Document new community roles #394
Conversation
e37f3af
to
98c10e6
Compare
f5c1824
to
8dc56e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Is this target to 4.13 on purpose?
I'm thinking maybe we need to have a formal signed agreement before granting people access. But that can maybe be sorted out later.
8dc56e0
to
834e2a1
Compare
Yes. Anything that affects both CMS 4 and 5 or which doesn't apply to a specific version should target Ideally these pages wouldn't be stuck behind a version toggle - see silverstripe/doc.silverstripe.org#245
Yup, we can update the docs if/when we have such an agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there.
834e2a1
to
19cb2f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The branch this PR is targetting now has a CI action. This PR will need to be force-pushed to run the CI, and the CI must be green before merging.
Rebased and resolved conflicts, lint passes locally. |
19cb2f8
to
384b965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing left is a pedantic and egocentric argument about my Job title.
384b965
to
7c7ed94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue