Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Remove mfa #66

Closed
wants to merge 2 commits into from
Closed

Remove mfa #66

wants to merge 2 commits into from

Conversation

bergice
Copy link
Contributor

@bergice bergice commented Jun 9, 2020

@brynwhyman brynwhyman mentioned this pull request Jun 9, 2020
Closed
3 tasks
@bergice bergice changed the base branch from 2.5 to 2 June 10, 2020 03:55
@dnsl48
Copy link
Contributor

dnsl48 commented Jun 10, 2020 •
edited
Loading

merge checklist

  • the target branch is correct
  • all commits are relevant (e.g. no debugging and linting)
  • the commit messages follow the contribution guidelines
  • the patch follows the contribution guidelines
  • new features are covered with tests (back-end with unit tests, front-end with Behat)
  • the relevant CMS documentation is updated; changelog for impactful changes
  • CI is green
  • at least one peer reviewer approved; no changes requested

dnsl48
dnsl48 suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase

Garion Herman and others added 2 commits June 12, 2020 00:54
@bergice
FIX Apply mcrypt requirement
365f646
@bergice
DOCS new branding in cwp change log template
79d1ac9 
One sentence really needed a re-work, so I've also updated 'Silverstripe' to match recent branding changes. We'd be doing the same in future release announcements too.
@bergice bergice force-pushed the pulls/2.5/remove-mfa branch from a238b9a to 79d1ac9 Compare June 11, 2020 12:56
dnsl48
dnsl48 suggested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changelog patches supposed to be in the PR?

@bergice bergice closed this Jun 14, 2020
@bergice
Copy link
Contributor Author

bergice commented Jun 14, 2020

Moved to #67

@dnsl48 dnsl48 deleted the pulls/2.5/remove-mfa branch June 23, 2020 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnsl48 dnsl48 dnsl48 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergice @dnsl48