Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source tokens for HF fast tokenizers #133

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix source tokens for HF fast tokenizers #133

merged 1 commit into from
Oct 24, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Oct 18, 2024

  • update MT tutorial to demonstrate TranslationResult
  • incompatible with transformers>=4.42, because of breaking change in NLLB tokenizer

This change is Reviewable

- update MT tutorial to demonstrate TranslationResult
- incompatible with transformers>=4.42, because of breaking change in NLLB tokenizer
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (ca7fba2) to head (6f240b6).

Files with missing lines Patch % Lines
...translation/huggingface/hugging_face_nmt_engine.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   88.07%   88.07%   -0.01%     
==========================================
  Files         273      273              
  Lines       16039    16041       +2     
==========================================
+ Hits        14127    14128       +1     
- Misses       1912     1913       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

:lgtm:

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 3673392 into main Oct 24, 2024
14 checks passed
@ddaspit ddaspit deleted the input-tokens branch October 24, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants