Remove obsolete code from NmtModelFactory

sillsdev · Nov 22, 2023 · 9b68138 · 9b68138
1 parent 4faa596
commit 9b68138
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/machine/jobs/huggingface/hugging_face_nmt_model_factory.py b/machine/jobs/huggingface/hugging_face_nmt_model_factory.py
@@ -70,11 +70,7 @@ def create_model_trainer(self, corpus: ParallelTextCorpus) -> Trainer:
             add_unk_trg_tokens=self._config.huggingface.tokenizer.add_unk_trg_tokens,
         )
 
-    def create_engine(self, half_previous_batch_size=False) -> TranslationEngine:
-        if half_previous_batch_size:
-            self._config.huggingface.generate_params.batch_size = max(
-                self._config.huggingface.generate_params.batch_size // 2, 1
-            )
+    def create_engine(self) -> TranslationEngine:
         return HuggingFaceNmtEngine(
             self._model,
             src_lang=self._config.src_lang,

diff --git a/machine/jobs/nmt_model_factory.py b/machine/jobs/nmt_model_factory.py
@@ -29,7 +29,7 @@ def create_model_trainer(self, corpus: ParallelTextCorpus) -> Trainer:
         ...
 
     @abstractmethod
-    def create_engine(self, half_previous_batch_size=False) -> TranslationEngine:
+    def create_engine(self) -> TranslationEngine:
         ...
 
     @abstractmethod

diff --git a/tests/jobs/test_nmt_engine_build_job.py b/tests/jobs/test_nmt_engine_build_job.py
@@ -18,7 +18,6 @@ def test_run(decoy: Decoy) -> None:
     env = _TestEnvironment(decoy)
     env.job.run()
 
-    decoy.verify(env.engine.translate_batch(matchers.Anything()), times=1)
     pretranslations = json.loads(env.target_pretranslations)
     assert len(pretranslations) == 1
     assert pretranslations[0]["translation"] == "Please, I have booked a room."