Revert "fixes and checks for build errors"

This reverts commit 5d89837.
sillsdev · Dec 13, 2023 · 5203d87 · 5203d87
1 parent 5d89837
commit 5203d87
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -31,7 +31,7 @@
         "eng_Latn",
         "--clearml",
         "--build-options",
-        "{\"huggingface\": {\"max_steps\": 10}}"
+        "{\"max_steps\": 10}"
       ]
     },
     {
@@ -41,4 +41,4 @@
       "justMyCode": false
     }
   ]
-}
+}
diff --git a/machine/jobs/huggingface/hugging_face_nmt_model_factory.py b/machine/jobs/huggingface/hugging_face_nmt_model_factory.py
@@ -26,10 +26,10 @@ def __init__(self, config: Any, shared_file_service: SharedFileService) -> None:
         args = config.huggingface.train_params.to_dict()
         args["output_dir"] = str(self._model_dir)
         args["overwrite_output_dir"] = True
-        if "max_steps" in self._config.huggingface:
+        if "max_steps" in self._config:
             if self._config.max_steps > 50000:
                 raise ValueError("max_steps must be less than or equal to 50000")
-            args["max_steps"] = self._config.huggingface.max_steps
+            args["max_steps"] = self._config.max_steps
         parser = HfArgumentParser(cast(Any, Seq2SeqTrainingArguments))
         self._training_args = cast(Seq2SeqTrainingArguments, parser.parse_dict(args)[0])
         if (

diff --git a/machine/jobs/nmt_engine_build_job.py b/machine/jobs/nmt_engine_build_job.py
@@ -86,7 +86,7 @@ def run(
             writer = stack.enter_context(self._shared_file_service.open_target_pretranslation_writer())
             current_inference_step = 0
             phase_progress(ProgressStatus.from_step(current_inference_step, inference_step_count))
-            batch_size = self._config.huggingface.batch_size
+            batch_size = self._config["batch_size"]
             for pi_batch in batch(src_pretranslations, batch_size):
                 if check_canceled is not None:
                     check_canceled()

diff --git a/machine/jobs/settings.yaml b/machine/jobs/settings.yaml
@@ -1,9 +1,9 @@
 default:
   model_type: huggingface
+  max_steps: 20000
   data_dir: ~/machine
+  batch_size: 1024
   huggingface:
-    max_steps: 20000
-    batch_size: 1024
     parent_model_name: facebook/nllb-200-distilled-1.3B
     train_params:
       do_train: true
@@ -31,8 +31,8 @@ development:
     generate_params:
       num_beams: 1
 staging:
+  max_steps: 10
   huggingface:
-    max_steps: 10
     parent_model_name: facebook/nllb-200-distilled-600M
     generate_params:
       num_beams: 1