Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update invite to project test to work with new 'invite' checkbox #994

Conversation

psh0078
Copy link
Collaborator

@psh0078 psh0078 commented Aug 1, 2024

fixes #993 and updates README.md

email workflow test needed to be modified to account for the invite checkbox functionality, so the instruction to add the invite checkbox is now added.

Copy link

github-actions bot commented Aug 1, 2024

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f13fce4. ± Comparison against base commit dcb4fc9.

♻️ This comment has been updated with latest results.

@psh0078 psh0078 marked this pull request as ready for review August 1, 2024 03:25
@psh0078 psh0078 requested a review from hahn-kev August 1, 2024 04:06
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a couple of renames: "checkbox" is too generic a name and doesn't communicate what it is.

frontend/tests/components/addMemberModal.ts Outdated Show resolved Hide resolved
frontend/tests/components/addMemberModal.ts Outdated Show resolved Hide resolved
@psh0078 psh0078 merged commit 7be3280 into develop Aug 2, 2024
9 checks passed
@psh0078 psh0078 deleted the bug/update-invite-to-project-test-to-work-with-invite-checkbox branch August 2, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update inviate to project test to work with new 'invite' checkbox
2 participants