Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up FLEx-lite view permissions and API features #861

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Jun 5, 2024

Resolves #862

This PR adds the concepts of:

  • permissions
  • API features
    to FLEx-lite and the 3 APIs we use.

So, now the UI only displays supported features (with the ability to toggle them in dev mode)

It also replaces the FLEx-lite header with the name of the project, so that we don't have to think about branding yet.

I wasn't sure where to best introduce the API features, so I'm intrested to hear if there are other ideas.

Copy link

github-actions bot commented Jun 5, 2024

UI unit Tests

11 tests   11 ✅  0s ⏱️
 3 suites   0 💤
 1 files     0 ❌

Results for commit 9a184af.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I've been meaning to do something like this

@myieye myieye merged commit a224c0f into develop Jun 6, 2024
9 checks passed
@myieye myieye deleted the feat/flex-lite-features-and-permissions branch June 6, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the viewer API-feature aware
2 participants