Download large test repo once, then store in image #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to skip the lengthy step of downloading elawa.zip from Google Drive every time `skaffold delete` gets run, or the hg-repos volume gets deleted.
|
I suspect the |
hahn-kev
requested changes
Jun 4, 2024
This restores the develop and staging environments to their previous state.
If running as non-root, mkdir /init-repos will fail, so we will instead download files (if necessary) into /tmp. The alternative would be to run this initContainer as root, then do a chown -R www-data:www-data on the newly-created repos.
There's no reason to unzip the sena-3.zip (or elawa.zip) files into the dev's Git worktree any more. We had been doing this to populate the repos volume when using Docker Compose, but now that we've switched to Skaffold, this step is useless, so we'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to skip the lengthy step of downloading elawa.zip from Google Drive every time
skaffold deletegets run, or the hg-repos volume gets deleted.Fixes #758.