Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure www-data owns repo structure and permissions are correct #821

Merged
merged 2 commits into from
May 28, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented May 24, 2024

Resolves #770

I opted to move all references to directory names into .NET / the HgService, so it's all in one place.
The initContainer ensures that .NET has permission to do whatever it wants in the volume root.

lost+found continues to be a comical exception 😆.

@myieye myieye requested review from rmunn and hahn-kev May 24, 2024 15:23
Copy link

github-actions bot commented May 24, 2024

C# Unit Tests

35 tests  ±0   35 ✅ ±0   5s ⏱️ -1s
 8 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5ac28a3. ± Comparison against base commit 5c40148.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! a couple minor suggestions, including one I heard about in another PR 😉

backend/LexBoxApi/Services/HgService.cs Outdated Show resolved Hide resolved
deployment/base/lexbox-deployment.yaml Show resolved Hide resolved
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below; I'm a bit concerned about how often StartAsync would run.

backend/LexBoxApi/LexBoxKernel.cs Show resolved Hide resolved
deployment/base/lexbox-deployment.yaml Show resolved Hide resolved
@myieye myieye merged commit fb43c1c into develop May 28, 2024
8 checks passed
@myieye myieye deleted the bug/ensure-www-data-owns-repo-structure branch May 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't delete projects in develop
3 participants