Invite guest users by email, don't add right away #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to change the Create User dialog for admins, and the Bulk Add feature, to send invitation emails to any users who have an email address, rather than automatically adding them without their input. This means that some invitation emails will need to be sent out without a project ID attached.
Now, when admins add an email address to the bulk-add dialog, that user will receive an invitation email instead of being added immediately.
Now admins will create users if they just have usernames, but send email invites instaed if they type an email address.
rmunn
changed the title
myieye
requested changes
May 28, 2024
There was a problem hiding this comment.
I haven't really looked at the code.
But I really don't like this approach to solving the problem. 😢
So, I'm just making that explicit here as well 😉.
I don't suggest actually making any changes until there's a consensus.
|
Talked with Tim about this and I don't actually think this is the way we will go. Sorry for sending you down the wrong path @rmunn that's my fault. My thoughts are here: #815 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815.
Now the bulk-add button and the Create User modal will send invitations, rather than creating user accounts immediately, if an email address is given. (Username-only accounts are still created immediately, because we don't have an email address to send an invite to.)