add health check for hgweb to match api version #679
Conversation
C# Unit Tests35 tests 35 ✅ 4s ⏱️ Results for commit 899e635. ♻️ This comment has been updated with latest results. |
|
It won't work properly in develop, because we only deploy what changed, is that right?
So, yeah, disabling it in develop sounds good to me. |
|
Yeah that's right about develop, we only push the changes that were made. |
There was a problem hiding this comment.
So, it seems to be working, but what do we get out of this?
[lexbox-api] warn: Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService[103]
[lexbox-api] => TraceId:fd6314267ee0210d42d107a3b5fbc5f7 => ConnectionId:0HN2JQPNPPUSR => RequestPath:/api/healthz RequestId:0HN2JQPNPPUSR:00000001 => Microsoft.Extensions.Diagnostics.HealthChecks.HealthCheckLogScope
[lexbox-api] Health check hgweb with status Degraded completed after 50.4235ms with message 'api version: 'dockerDev' hg version: 'dockerDev2' mismatch'
I don't see the degraded status anywhere in k8s and it deploys the version regardless of the health being degraded. What do we want to happen?
|
that's a good point, my thinking was that the deploy script would catch it, but right now it only checks the version header and not the status code to see the response. Need to fix the script to keep trying until the service is healthy |
Pull request was converted to draft
# Conflicts: # backend/LexBoxApi/LexBoxKernel.cs # hgweb/command-runner.sh
UI unit Tests11 tests 11 ✅ 0s ⏱️ Results for commit 899e635. ♻️ This comment has been updated with latest results. |
this adds a health check to the api so when /api/healthz is called it verifies that hgweb is running the same version, if it's not then the health is degraded.
todo:
closes #672