Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use custom collation for sorting LcmCrdt data #1291

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Nov 29, 2024

defines a custom collation for each writing system providing a custom compare function to Sqlite, this lets us utilize Sqlite sorting our data while still having full control over how sorting is performed. For now we're using standard C# sorting, but in the future we could implement custom sort rules from ICU

closes #1125

Copy link

github-actions bot commented Nov 29, 2024

C# Unit Tests

98 tests  ±0   98 ✅ ±0   5s ⏱️ ±0s
15 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 2465d7e. ± Comparison against base commit ada6d56.

♻️ This comment has been updated with latest results.

myieye
myieye previously approved these changes Nov 29, 2024
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

image

backend/FwLite/LcmCrdt/Data/SqlSortingExtensions.cs Outdated Show resolved Hide resolved
@hahn-kev hahn-kev merged commit 62e2c19 into develop Nov 29, 2024
16 checks passed
@hahn-kev hahn-kev deleted the chore/sorting-case-insensitive branch November 29, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crdt viewer headword sort puts capitalized headwords first
2 participants