Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1271 clicking on a draft project on the admin dashboard results in a gql error #1272

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Nov 25, 2024

Resolves #1271

Presumably with our upgrade of HotChocolate the draft approval process broke 🤯, because HC added security against large/complex queries by (e.g.) enforcing explicit paging.

@myieye myieye requested a review from hahn-kev November 25, 2024 12:19
Copy link

github-actions bot commented Nov 25, 2024

UI unit Tests

12 tests   12 ✅  0s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 3dcfa17.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I added a small feature to make it easier to create draft projects

Copy link

C# Unit Tests

90 tests  ±0   90 ✅ ±0   5s ⏱️ ±0s
14 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 3dcfa17. ± Comparison against base commit a525563.

@myieye myieye merged commit c54f64d into develop Nov 27, 2024
14 checks passed
@myieye myieye deleted the bug/1271-clicking-on-a-draft-project-on-the-admin-dashboard-results-in-a-gql-error branch November 27, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on a draft project on the admin dashboard results in a GQL error
2 participants