-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for syncing complex forms twice #1256
Conversation
The second sync, that should do nothing, was importing the seed data, including the parts of speech and semantic domains that weren't in fwdata after the first sync.
This was not successful at reproducing the issue we encounter syncing sena-3, because this test is passing. I'll keep working at it.
I just synced elawa multiple times and each time the number of fwdata changes decreased, but it took about 5 syncs before it was 0. |
… in a second pass update those entries so they contain those complex forms
Since the CreatingAComplexEntryInFwDataSyncsWithoutIssue test doesn't actually test the bug from #1251, we might want to delete it. But this is ready for review regardless, whether or not we decide to delete CreatingAComplexEntryInFwDataSyncsWithoutIssue. |
…sts and into SyncTests
…hich only show up when running all tests at once
… headwords get set so that they match what we get from fieldworks
…crdt-twice-should-not-throw
…isn't on the entry
… where test host hangs once tests are done
…t to avoid issues where the complex form does not get created because it's referencing an entry which does not exist
…the data causing the problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmunn I've got this working now. I'd like to see the Sena3 fixture cleanup after itself so we don't just create a bunch of copies of projects every time the tests are run. I'd do the cleanup before the test run so in a failure you can investigate the results.
edit: also I just merged #1264 into this PR since they were closely related, I'll just close it once this PR is merged in.
To delete a CRDT project, is it enough to delete the |
backend/FwLite/FwLiteProjectSync.Tests/Fixtures/Sena3SyncFixture.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just got a couple suggestions.
But, there are tests failing, so I feel like I'm not late 🙃
Integration test to verify whether #1251 has been fixed.