Skip to content

Commit

Permalink
use versions instead of sha for well known github actions
Browse files Browse the repository at this point in the history
  • Loading branch information
hahn-kev committed Apr 25, 2024
1 parent 8c147b0 commit e1b2f7d
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ jobs:
ui-version: ${{ steps.get-ui-version.outputs.result }}
steps:
- name: Checkout lexbox repo
uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
uses: actions/checkout@v4
with:
path: lexbox
- name: Run kustomize
working-directory: lexbox/deployment/${{ inputs.k8s-environment }}
run: |
kubectl kustomize . -o resources.yaml
- name: Checkout fleet repo
uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
uses: actions/checkout@v4
with:
repository: ${{ vars.FLEET_REPO }}
ssh-key: ${{ secrets.FLEET_REPO_SSH_KEY }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/develop-ui.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ jobs:
run:
working-directory: ./frontend
steps:
- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@a3252b78c470c02df07e9d59298aecedc3ccdd6d # v3.0.0
with:
package_json_file: 'frontend/package.json'
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
- uses: actions/setup-node@v4
with:
node-version-file: './frontend/package.json'
cache: 'pnpm'
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/integration-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
name: ${{ inputs.environment }}
runs-on: ${{ inputs.runs-on }}
steps:
- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
- uses: actions/checkout@v4
- uses: testspace-com/[email protected]
with:
domain: ${{ github.repository_owner }}
Expand All @@ -67,7 +67,7 @@ jobs:
rm powershell_7.4.1-1.deb_amd64.deb
pwsh #validate that powershell installed correctly
# First we need to setup Node...
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
- uses: actions/setup-node@v4
if: ${{ inputs.run-playwright }}
with:
node-version-file: 'frontend/package.json'
Expand All @@ -77,13 +77,13 @@ jobs:
with:
package_json_file: 'frontend/package.json'
# Then we can have Noede set up package caching
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
- uses: actions/setup-node@v4
if: ${{ inputs.run-playwright }}
with:
node-version-file: 'frontend/package.json'
cache: 'pnpm'
cache-dependency-path: 'frontend/pnpm-lock.yaml'
- uses: actions/setup-dotnet@4d6c8fcf3c8f7a60068d26b594648e99df24cee3 # v4.0.0
- uses: actions/setup-dotnet@v4
env:
DOTNET_INSTALL_DIR: ${{ inputs.runs-on == 'self-hosted' && '/opt/hostedtoolcache/dotnet' || '' }} #poor man's conditional
with:
Expand Down Expand Up @@ -164,7 +164,7 @@ jobs:
run: testspace "[.Net Integration]./test-results/*.trx" "[Playwright]./frontend/test-results/*.xml"
- name: Upload playwright results
if: ${{ always() && steps.password_protect_test_results.outcome == 'success' }}
uses: actions/upload-artifact@1746f4ab65b179e0ea60a494b83293b640dd5bba # v4.3.2
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ inputs.runs-on }}-hg-${{ inputs.hg-version }}
path: ./playwright-traces.7z
6 changes: 3 additions & 3 deletions .github/workflows/lexbox-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ jobs:
DOCKER_BUILDKIT: 1

steps:
- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
- uses: actions/setup-dotnet@4d6c8fcf3c8f7a60068d26b594648e99df24cee3 # v4.0.0
- uses: actions/checkout@v4
- uses: actions/setup-dotnet@v4
with:
dotnet-version: '8.x'
- name: Dotnet build
Expand All @@ -60,7 +60,7 @@ jobs:
files: ./test-results/*.xml
- name: Upload test results
if: always()
uses: actions/upload-artifact@1746f4ab65b179e0ea60a494b83293b640dd5bba # v4.3.2
uses: actions/upload-artifact@v4
with:
name: dotnet-unit-test-results
path: ./test-results
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lexbox-hasura.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

steps:
-
uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
uses: actions/checkout@v4
- name: Set Version
id: setVersion
# set version to date in vYYYY-MM-DD format
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lexbox-hgweb.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:

steps:
-
uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
uses: actions/checkout@v4
- name: Set Version
id: setVersion
if: ${{ !env.VERSION }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lexbox-ui.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
DOCKER_BUILDKIT: 1

steps:
- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f # v4.1.3
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: './frontend/package.json'
- name: pnpm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/package-cleanup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- 'lexbox-api'
- 'lexbox-hgweb'
steps:
- uses: actions/delete-package-versions@ve5bc658cc4c965c472efe991f8beea3981499c55 # v5.0.0
- uses: actions/delete-package-versions@v5
with:
package-name: ${{ matrix.package-name }}
package-type: 'container'
Expand Down

0 comments on commit e1b2f7d

Please sign in to comment.