Add Update(before, after) API for senses #487
rmunnfw-lite.yaml
on: pull_request
Build FW Lite and run tests
10m 30s
Publish FW Lite app for Mac
0s
Publish FW Lite app for Linux
0s
Publish FW Lite app for Windows
0s
Create Release
0s
Annotations
2 errors and 11 warnings
|
FwLiteProjectSync.Tests.UpdateDiffTests.SenseDiffShouldUpdateAllFields:
backend/FwLite/FwLiteProjectSync.Tests/UpdateDiffTests.cs#L40
Expected property before.SemanticDomains to be a collection with 1 item(s), but found an empty collection.
With configuration:
- Use declared types and members
- Compare enums by value
- Compare tuples by their properties
- Compare anonymous types by their properties
- Compare records by their members
- Include non-browsable members
- Exclude member Id
- Exclude member EntryId
- Exclude member DeletedAt
- Exclude member ExampleSentences
- Match member by name (or throw)
- Be strict about the order of items in byte arrays
- Without automatic conversion.
|
|
Build FW Lite and run tests
Process completed with exit code 1.
|
|
Build FW Lite and run tests:
backend/FwLite/FwLiteProjectSync.Tests/Fixtures/Sena3SyncFixture.cs#L31
Dispose synchronously blocks. Await DisposeAsync instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD103.md)
|
|
Build FW Lite and run tests:
backend/FwLite/MiniLcm/SyncHelpers/WritingSystemSync.cs#L21
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/MiniLcm/SyncHelpers/SenseSync.cs#L41
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L204
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
|
|
Build FW Lite and run tests:
backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
|
|
Build FW Lite and run tests:
backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateEntryProxy.cs#L53
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L18
Parameter 'dbContext' is unread.
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|