Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add app_name and app_env to subnet Name tag #4

Merged
merged 1 commit into from
Dec 2, 2024
Merged

add app_name and app_env to subnet Name tag #4

merged 1 commit into from
Dec 2, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Dec 2, 2024

Changed

  • Added app_name and app_env to the subnet Name tag

@briskt briskt requested a review from a team as a code owner December 2, 2024 03:34
@briskt briskt requested review from forevermatt, jason-jackson, hobbitronics and Praveenraj-K and removed request for a team December 2, 2024 03:34
hobbitronics
hobbitronics approved these changes Dec 2, 2024
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@briskt briskt merged commit 215ca55 into main Dec 2, 2024
1 check passed
@briskt briskt deleted the subnet-name branch December 2, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/tf-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/tf-devs

@Praveenraj-K Praveenraj-K Awaiting requested review from Praveenraj-K Praveenraj-K is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics