Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Commit

Permalink
Merge pull request #33 from silinternational/develop
Browse files Browse the repository at this point in the history
Release 1.2.2 - Fix lack of `callback` when loading Google Maps JavaScript API
  • Loading branch information
forevermatt authored Mar 7, 2024
2 parents 5f32c08 + 9ba8dfe commit af9cb0f
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 4 deletions.
29 changes: 29 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
### Added
-

### Changed
-

### Deprecated
-

### Removed
-

### Fixed
-

### Security
-

---

### Release PR Checklist
- [ ] Update version number in package.json
- [ ] Run `make install` to update version number in package-lock.json
- [ ] Make sure everything looks good in a DRY RUN of publishing this to npm: `npm publish --dry-run`

After merge...
- [ ] Tag that commit on `master`
- [ ] Check out that commit
- [ ] Publish that version to NPM: `npm publish --access public`
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@silintl/svelte-google-places-autocomplete",
"version": "1.2.0",
"version": "1.2.2",
"description": "A minimal port of the [Google Places Autocomplete API](https://developers.google.com/maps/documentation/javascript/places-autocomplete) as a Svelte component.",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion src/loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function loadGooglePlacesLibrary(apiKey, callback) {
element.async = true
element.defer = true
element.onload = onLibraryLoaded
element.src = `https://maps.googleapis.com/maps/api/js?key=${encodeURIComponent(apiKey)}&libraries=places`
element.src = `https://maps.googleapis.com/maps/api/js?key=${encodeURIComponent(apiKey)}&libraries=places&callback=Function.prototype`
element.type = 'text/javascript'

document.head.appendChild(element)
Expand Down

0 comments on commit af9cb0f

Please sign in to comment.