Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve local development #299

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Improve local development #299

merged 2 commits into from
Dec 3, 2024

Conversation

forevermatt
Copy link
Contributor

Fixed

  • Specify platform for non-cross-platform docker images (for local dev)
  • Increase timeout when tests are waiting for local IDP to start up
    • Five seconds was not long enough one of the times I was running the integration tests locally.

@forevermatt forevermatt requested a review from a team as a code owner December 2, 2024 21:02
@forevermatt forevermatt requested review from briskt, mtompset, jason-jackson and hobbitronics and removed request for a team December 2, 2024 21:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@forevermatt forevermatt merged commit 3f669bf into main Dec 3, 2024
4 checks passed
@forevermatt forevermatt deleted the feature/improve-local-development branch December 3, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @briskt