Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 10.0.0-alpha.7 -- miscellaneous fixes #265

Merged
merged 21 commits into from
Jul 18, 2024
Merged

Release 10.0.0-alpha.7 -- miscellaneous fixes #265

merged 21 commits into from
Jul 18, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 18, 2024

Fixed

  • Use preferred ENV=value syntax in Dockerfile
  • Correct the Metadata utils path in sildisco/metadata.php
  • Added a null coalesce on $state['mfaLearnMoreUrl'] for the review page
    • fixes error: SimpleSAML\Error\Exception: Warning - Undefined array key "mfaLearnMoreUrl" at /data/vendor/simplesamlphp/simplesamlphp/modules/profilereview/public/nag.php:37
  • Defined exampleauth:UserPass users in users key
    • fixes error: Module exampleauth:UserPass configured in legacy mode. Please put your username:password entries under the "users" key in your authsource.
  • Changed from if to assert to catch error condition earlier
  • Stop using the admin module to access the hub discovery page
    • fixes error: Caused by: Twig\Error\RuntimeError: An exception has been thrown during the rendering of a template ("SimpleSAML\XHTML\Template::getEntityDisplayName(): Argument #⁠1 ($data) must be of type array, null given, called in /data/vendor/twig/twig/src/Environment.php(392) : eval()'d code on line 82").
  • Filled in missing data in authsources.php
    • fixes error: SimpleSAML\Error\Exception: Warning - Undefined array key "add" at /data/vendor/simplesamlphp/simplesamlphp/modules/profilereview/src/Auth/Process/ProfileReview.php:234

Removed

  • Removed browser check for webauthn support
  • Removed abandoned package sinergi/browser-detector
  • In Dockerfile:
    • Removed ENV REFRESHED_AT
    • Removed RUN mkdir -p /data
    • Removed s3-expand
    • Removed RUN chmod a+x /data/run.sh /data/run-tests.sh
  • Removed index.php override, originally added to call autoload.php, no longer needed
  • Removed id.php override, originally added for load balancer, no longer needed
  • Removed announcement.php placeholder
  • Removed material logout template. We have no need of this since logout redirects back to the SP.
  • Removed support for the enabled metadata IdP attribute

Changed

  • Updated php-env and use null as the default for getArray for TRUSTED_URL_DOMAINS

briskt added 21 commits July 17, 2024 12:37
fixes error shown in test log output:
SimpleSAML\Error\Exception: Warning - Undefined array key "add" at /data/vendor/simplesamlphp/simplesamlphp/modules/profilereview/src/Auth/Process/ProfileReview.php:234
fixes error shown in test log output:
Caused by: Twig\Error\RuntimeError: An exception has been thrown during the rendering of a template ("SimpleSAML\XHTML\Template::getEntityDisplayName(): Argument #1 ($data) must be of type array, null given, called in /data/vendor/twig/twig/src/Environment.php(392) : eval()'d code on line 82").
and remove incorrect log message
fixes error shown in test log output:
Module exampleauth:UserPass configured in legacy mode. Please put your username:password entries under the "users" key in your authsource.
fixes error:
impleSAML\Error\Exception: Warning - Undefined array key "mfaLearnMoreUrl" at /data/vendor/simplesamlphp/simplesamlphp/modules/profilereview/public/nag.php:37
…detector

remove browser check for webauthn support
put the Dockerfile on a weight loss program
Copy link

@briskt briskt merged commit f4ea746 into main Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants