Release 10.0.0-alpha.6 -- update sildisco module for SSP 2

[briskt]

Changed

• Re-enabled sildisco for IdP discovery.
• Fixed SP name display on sildisco IdP selection page.
• Use entityDisplayName Twig filter for displaying the IdP and SP names.
• Updated test metadata to include entityid in every entry, and make name an array.
• Patch the standard SP AuthSource to modify behavior when multiple IdPs are available for an SP.
  • When more than one IdP is available, always present the discovery page. Standard behavior is to proceed using an existing IdP session if possible.
  • When re-authentication is required, always present the discovery page. Standard behavior is to let the user choose whether to cancel or continue.

Removed

• Removed source files copied from SimpleSAMLphp that are no longer used.
• Removed leftover dictionary files from pre-SSP2
• Removed actions-services.yml
• Removed patch from run.sh
• Removed "beta test" feature. We do not use this in staging or production.

Fixed

• Fixed the SingleLogoutService on the test IdPs to use the standard saml2-logout.php since it no longer needs to be customized.
• Added use statements to import classes
• Removed unnecessary use statements

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
10.9% Duplication on New Code

See analysis details on SonarCloud

[hobbitronics]

Can't say I've reviewed all of the code but on the basis that someone has it should be ok. On the other hand you might wan't someone else to tick the box.

[briskt]

Can't say I've reviewed all of the code but on the basis that someone has it should be ok. On the other hand you might wan't someone else to tick the box.

Thanks. Previous reviews should be enough, but if other people are willing and available, I wouldn't turn away more input (before or after merge).

[forevermatt]

If the SP Entity ID is empty, does this mean that the IDP List used might now include more entries than it should (since it won't be reduced)?

[briskt]

Yes. Do you think it would be better to throw an exception instead?

[forevermatt]

I think so. It may be that we try it and learn that's not what we want, but I'd rather err on the side of failing loudly rather than silently.