clean up logged error messages #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes error shown in test log output: SimpleSAML\Error\Exception: Warning - Undefined array key "add" at /data/vendor/simplesamlphp/simplesamlphp/modules/profilereview/src/Auth/Process/ProfileReview.php:234
fixes error shown in test log output:
Caused by: Twig\Error\RuntimeError: An exception has been thrown during the rendering of a template ("SimpleSAML\XHTML\Template::getEntityDisplayName(): Argument #1 ($data) must be of type array, null given, called in /data/vendor/twig/twig/src/Environment.php(392) : eval()'d code on line 82").
and remove incorrect log message
fixes error shown in test log output: Module exampleauth:UserPass configured in legacy mode. Please put your username:password entries under the "users" key in your authsource.
fixes error: impleSAML\Error\Exception: Warning - Undefined array key "mfaLearnMoreUrl" at /data/vendor/simplesamlphp/simplesamlphp/modules/profilereview/public/nag.php:37
|
forevermatt
reviewed
Jul 22, 2024
| $spmd = $state['SPMetadata']; | ||
| $this->log('Updated SP metadata from ' . $this->spEntityId . ' to ' . $spmd['entityid']); | ||
| } | ||
| assert($state && array_key_exists('SPMetadata', $state)); |
There was a problem hiding this comment.
I don't think we want to depend on PHP's built in assert() function, since it is typically only run in debug or test mode, and is disabled in production mode (per the docs).
If we want to ensure something is asserted every time, it seems to be better to use other/normal PHP code (either an if and throw new Exception, or something like WebMozart's "Assert" library).
There was a problem hiding this comment.
Oh, I didn't realize that. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
$state['mfaLearnMoreUrl']for the review pageexampleauth:UserPassusers inuserskeyiftoassertto catch error condition earlier