Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the AddIdp2NameId filter #254

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix the AddIdp2NameId filter #254

merged 3 commits into from
Jul 16, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 16, 2024

Fixed

  • Fixed the AddIdp2NameId filter and sildisco unit tests

forevermatt
forevermatt reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question added, but overall it looks good.

@briskt briskt requested a review from forevermatt July 16, 2024 16:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@briskt briskt merged commit 3e4c520 into develop Jul 16, 2024
2 of 3 checks passed
@briskt briskt deleted the feature/fix-add-idp-2-nameid branch July 16, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

@mtompset mtompset Awaiting requested review from mtompset

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

@hobbitronics hobbitronics Awaiting requested review from hobbitronics

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @forevermatt