Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.0.0-alpha.5 -- more fixes for SimpleSAMLphp 2 #249

Merged
merged 17 commits into from
Jul 10, 2024
Merged

Release 10.0.0-alpha.5 -- more fixes for SimpleSAMLphp 2 #249

merged 17 commits into from
Jul 10, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 10, 2024

Changed

  • Update Twig templates to recommended style (space after colon, snake case vars)

Fixed

  • Changed getString to getOptionalString (and similar changes)
  • Instantiate SimpleSAMLphp Utils classes
  • Define variables needed in the header template (analytics_tracking_id and theme_color_scheme)

briskt added 17 commits July 2, 2024 14:34
@briskt
add space after colon in Twig maps
f98d444
@briskt
change twig variables to snake case
1251a6b
@briskt
change getString to getOptionalString where a default is provided
ab2c25d
@briskt
make more type safe
ace05ab
@briskt
instantiate SimpleSAML\Utils classes
847f4a6
@briskt
replace getValue with new type-specific methods
efcce39
@briskt
replace getBoolean with getOptionalBoolean
e7a995e
@briskt
PR feedback: add "new" in Utils\Metadata() instantiation
332ecff
@briskt
Merge pull request #244 from silinternational/feature/twig-style
99617a2 
use recommended style for Twig templates
@briskt
Merge pull request #245 from silinternational/feature/get-optional-st…
6945cda 
…ring

change getString to getOptionalString where a default is provided
@briskt
Merge branch 'develop' into feature/instantiate-utils
cf239c1
@briskt
Merge pull request #246 from silinternational/feature/instantiate-utils
dfc6b6e 
instantiate SimpleSAML\Utils classes
@briskt
define variables needed in the header template
dc5f782
@briskt
still need to check undefined analytics_tracking_id, theme_color_scheme
7c18365 
Any template instantiated by SSP code will not have defined our variables.
@briskt
Merge pull request #247 from silinternational/feature/ssp2-header-var…
6db9caf 
…iables

define variables needed in the header template
@briskt
default theme_color_scheme to null rather than empty string
97de2cf
@briskt
add IdP logos for development
095efeb
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.8% Duplication on New Code

See analysis details on SonarCloud

mtompset
mtompset approved these changes Jul 10, 2024
View reviewed changes
Copy link

@mtompset mtompset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole swap to snake case made this extra long. Hopefully there are no values missing in the midst of all those cuts and changes.

@briskt
Copy link
Contributor Author

briskt commented Jul 10, 2024

The whole swap to snake case made this extra long. Hopefully there are no values missing in the midst of all those cuts and changes.

You're right. Fortunately, since the check for undefined template variables is enabled, and we have good test coverage, I think we're safe.

@briskt briskt merged commit 653686c into main Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtompset mtompset mtompset approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

@hobbitronics hobbitronics Awaiting requested review from hobbitronics

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @mtompset