convert backup code and manager code templates to Twig #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Base automatically changed from
feature/ss2-promptmfa-twig
to
feature/ssp2-mfasetup-twig
June 25, 2024 08:00
hobbitronics
approved these changes
Jun 25, 2024
| </button> | ||
| {% endif %} | ||
|
|
||
| <span flex></span> |
There was a problem hiding this comment.
how do these attributes like flex and layout-children="row" even work? Part of the MDL theme? I see its just part of the old file, but wondered if you know.
There was a problem hiding this comment.
I don't know. Sorry. Would you like to plan to do a technology/standards update for the UI code in this repo?
There was a problem hiding this comment.
Possibly. Since those aren't standard attributes I was just wondering where to find documentation on them. Not necessarily anything wrong with them.
|
I'll include the type="submit" in a later PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
https://itse.youtrack.cloud/issue/IDP-898