Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert mfa templates to Twig #235

Merged
merged 9 commits into from
Jun 26, 2024
Merged

convert mfa templates to Twig #235

merged 9 commits into from
Jun 26, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 19, 2024

Changed

  • Converted must-set-up-mfa.php template to Twig
  • Converted prompt-for-mfa templates to Twig

Added

  • Added .gitkeep files to make templates directories for modules. These will be filled during image creation, but need to exist for local development and test.
  • Added .gitkeep files to module locales folders. SSP requires these to exist, but we'll never use the non-themed locales directories.

https://itse.youtrack.cloud/issue/IDP-898

@briskt briskt requested a review from hobbitronics June 25, 2024 04:04
Base automatically changed from feature/ssp2-expired-twig to develop June 25, 2024 08:22
@briskt briskt changed the title convert must-set-up-mfa.php template to Twig convert mfa templates to Twig Jun 25, 2024
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one that needs to be changed is last comment, others are optional, but recommended.

Copy link

@briskt briskt merged commit f3ad6bf into develop Jun 26, 2024
1 of 2 checks passed
@briskt briskt deleted the feature/ssp2-mfasetup-twig branch June 26, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants