convert selectidp-links to Twig #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dp-twig [skip ci]
forevermatt
reviewed
Jun 24, 2024
|
hobbitronics
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Seems you've resolved all the great comments left by @forevermatt. I've added a few, but looks good and I think Twig seems like an improvement.
briskt
commented
Jun 25, 2024
forevermatt
reviewed
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
selectidp-linkstemplate to Twigdevelopment/hub/metadata/sp-remote.phptosaml20-sp-remote.phpand changed to the standard metadata format.development/hub/metadata/idp-remote.phptosaml20-idp-remote.phpand changed to the standard metadata format.betaenabledtestsFixed
UserPass.phpoverlay to the latest from the SimpleSAMLphp libraryRemoved
core:StatisticsWithAttributeauthproc as it was moved to another moduleDisabled features have been added to a checklist in IDP-869