Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.0.0-alpha.2 -- cleanup, twig prep, typehints #216

Merged
merged 58 commits into from
Jun 13, 2024
Merged

Release 10.0.0-alpha.2 -- cleanup, twig prep, typehints #216

merged 58 commits into from
Jun 13, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 12, 2024 •
edited
Loading

Added

  • Added an announcement file for local development
  • Added a test feature that logs the html and saves a screenshot on failure

Changed (breaking)

  • Always use the material theme
  • Added PHP typehints to module code

Changed (non-breaking)

  • Moved PHP code out of templates in preparation for conversion to Twig templating
  • Changed the name of the Actions test container to test
  • Include dev dependencies (e.g. behat) in the test image
  • Made the ADMIN_EMAIL variable no longer required
  • Updated files "lifted" from the SimpleSAMLphp library

Removed

  • Removed default theme files
  • Removed xdebug from the local development image
  • Removed old prompt-for-mfa-u2f.php template file
  • Removed duplicate copy of simplewebauthn browser.js file

Fixed

  • Fixed a "not found" error on the simplewebauthn browser.js file, which prevented use of a Webauthn 2sv option at login
  • Fixed failure in hub mode due to a missing dependency (AWS SDK)
  • Fixed failure to run complete migrations. Reverted the migration namespace back to the original (\Sil\SilAuth\migrations).
  • Better error handling for manager "rescue" code request failure

briskt added 30 commits May 24, 2024 17:15
@briskt
fix exception thrown when a user's password is about to expire
9ae69c4 
This error was shown in the browser:
```
SimpleSAML\Error\Error: UNHANDLEDEXCEPTION

Backtrace:
1 www/_include.php:20 (SimpleSAML_exception_handler)
0 [builtin] (N/A)
Caused by: TypeError: str_replace(): Argument #2 ($replace) must be of type array|string, float given
Backtrace:
7 lib/SimpleSAML/Locale/Translate.php:308 (str_replace)
6 lib/SimpleSAML/Locale/Translate.php:308 (SimpleSAML\Locale\Translate::t)
5 lib/SimpleSAML/XHTML/Template.php:914 (SimpleSAML\XHTML\Template::t)
4 modules/material/themes/material/expirychecker/about2expire.php:34 (require)
3 lib/SimpleSAML/XHTML/Template.php:560 (SimpleSAML\XHTML\Template::show)
2 modules/expirychecker/www/about2expire.php:63 (require)
1 lib/SimpleSAML/Module.php:266 (SimpleSAML\Module::process)
0 www/module.php:10 (N/A)
```
@briskt
fix exception thrown when a user is low on printable codes
e3730cc 
This error was shown in the browser:
```
SimpleSAML\Error\Error: UNHANDLEDEXCEPTION

Backtrace:
1 www/_include.php:20 (SimpleSAML_exception_handler)
0 [builtin] (N/A)
Caused by: TypeError: str_replace(): Argument #2 ($replace) must be of type array|string, int given
Backtrace:
7 lib/SimpleSAML/Locale/Translate.php:308 (str_replace)
6 lib/SimpleSAML/Locale/Translate.php:308 (SimpleSAML\Locale\Translate::t)
5 lib/SimpleSAML/XHTML/Template.php:914 (SimpleSAML\XHTML\Template::t)
4 modules/material/themes/material/mfa/low-on-backup-codes.php:32 (require)
3 lib/SimpleSAML/XHTML/Template.php:560 (SimpleSAML\XHTML\Template::show)
2 modules/mfa/www/low-on-backup-codes.php:35 (require)
1 lib/SimpleSAML/Module.php:266 (SimpleSAML\Module::process)
0 www/module.php:10 (N/A)
```
@briskt
remove the cast to int
ac6b1c2
@briskt
use material module for all tests
e019a44
@briskt
ensure daysLeft is int
5851807
@briskt
remove THEME_USE variable
80551ca
@briskt
remove templates not used by material theme
b9a3c4c
@briskt
copy material theme templates to other modules
76f4b74
@briskt
generate browser.js path in the controller, not the template
2e239d3
@briskt
remove extra dot that messed up the browser.js hash
ab9637e
@briskt
pass the announcement in as a template parameter
3f4f1f9
@briskt
move PHP code from other_mfas.php template into the controller
ba7eff6
@briskt
ensure recaptcha.siteKey is assigned in the controller
cc41526
@briskt
add announcement.php to actions-services.yml
de7c619
@briskt
Merge remote-tracking branch 'origin/develop' into feature/always-mat…
ddecb44 
…erial
@briskt
Merge remote-tracking branch 'origin/develop' into feature/fix-type-e…
f454b8b 
…rrors
@briskt
update match strings in mfa tests
be25aca
@briskt
Merge branch 'feature/always-material' into feature/remove-default-theme
3a24380
@briskt
Merge branch 'feature/remove-default-theme' into feature/twig-prep
308cb1e
@briskt
insert blank line after opening php tag [skip ci]
2e49085
@briskt
clarify comment about the purpose of authsources.php [skip ci]
24fd66b
@briskt
Merge pull request #207 from silinternational/feature/always-material
6f20c17 
use material module for all tests
@briskt
Merge pull request #200 from silinternational/feature/fix-type-errors
3386802 
fix type errors for two different login scenarios
@briskt
Merge pull request #208 from silinternational/feature/remove-default-…
6b77463 
…theme

remove default theme files
@briskt
Merge pull request #209 from silinternational/feature/twig-prep
352ef44 
prepare for Twig templating
@briskt
remove xdebug and add instructions to README
f5b8856
@briskt
use a new Docker arg to control composer install command flags
fa4cc40
@briskt
change container name to match docker-compose.yml
608cce6
@briskt
change the composer flags in actions-services.yml
2dbed26
@briskt
still need composer install for metadata tests
b44307e
briskt and others added 15 commits June 11, 2024 13:59
@briskt
Merge branch 'feature/type-hinting' of github.com:silinternational/ss…
1e9bd5b 
…p-base into feature/type-hinting
@briskt @jason-jackson
Update modules/sildisco/www/sp/discoresp.php
cbe50dc 
Co-authored-by: Jason Jackson <[email protected]>
@briskt
Merge pull request #214 from silinternational/feature/type-hinting
59cf871 
add typehints
@briskt
Merge pull request #215 from silinternational/feature/sync-to-1-19-9
5d884bd 
update simpleSAMLphp files to version 1.19.8
@briskt
save a screenshot when a test fails
f4c0934
@briskt
fix simplewebauthn/browser.js path
e983c4c
@briskt
allow mfa submission to be an array as well as a string
0a7de22
@briskt
revert the namespace change on migration files
ba13825 
Yii wanted to re-run all migrations because of the change
@briskt
move the migration files to the old namespace to avoid yii treating t…
a69735c 
…hem as new migrations
@briskt
move migrations into silauth directory and update yii2-config.php wit…
282dc5a 
…h new migrations location
@briskt
ADMIN_EMAIL (technicalcontact_email) is not mandatory or required
9320d6d
@briskt
avoid a logged error in nag controller
750fdf5
@briskt
better error handling for manager code request
03f3b5e
@briskt
adding missing dependency AWS SDK and updated installed-packages.json
b8943b3
@briskt
remove ADMIN_EMAIL dummy values for dev and test
b33f093
@briskt briskt requested a review from a team June 12, 2024 07:17
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@briskt
Copy link
Contributor Author

briskt commented Jun 12, 2024 •
edited
Loading

Most changes have been reviewed on a feature branch. Recent changes, such as bugs found while testing on the appsdev IdP and staging hub were committed to the develop branch. Reference this diff to see those changes isolated.

@briskt briskt requested a review from a team June 12, 2024 13:05
forevermatt
forevermatt approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with very minor (non-blocking) comments or questions. Thanks! 👍

development/idp-local/config/config.php Outdated Show resolved Hide resolved
features/bootstrap/FeatureContext.php Show resolved Hide resolved
modules/mfa/www/prompt-for-mfa.php Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
5.4% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit b0e8d10 into main Jun 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtompset mtompset mtompset left review comments

@forevermatt forevermatt forevermatt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @forevermatt @mtompset