Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share the use of static functions in Mfa authproc #213

Closed
wants to merge 1 commit into from

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 6, 2024

No description provided.

@briskt briskt requested a review from a team June 6, 2024 05:13
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine, but it feels a little odd to have one module import the another (this could just be me, and it's not a big issue at all - I'm totally fine with doing it). A couple questions/alternatives:

  1. Should the methods be moved out into a helper class instead? (Issue with this is where would it go?)
  2. Should ProfileReview extend module? (Issue being does it need to have all the other junk)

So overall, I think it's fine as is unless you have a good answer to any of the above questions. As I'm more concerned with the issues I have with alternatives than I am with this way.

@briskt
Copy link
Contributor Author

briskt commented Jun 11, 2024

Decided that the duplication is less of a problem than the module interdependency.

@briskt briskt closed this Jun 11, 2024
@briskt briskt deleted the feature/share-code branch June 11, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants