directly include the sildisco module #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forevermatt
reviewed
May 21, 2024
was: ssp-sp3.local:8084 and pwmanager.local:8083 now: ssp-sp3.local:8083 and pwmanager.local:8084 The reason is twofold: (1) this makes the ssp-sp[n].local container ports contiguous: 8081, 8082, and 8083, and (2) some of the references to ssp-sp3.local still had 8083 as was assigned in the simplesamlphp-module-sildisco repo.
- add the port number to ssp-sp3.local in the authsources.php config - remove reference to the "default-enable" file in the_hub.md
This makes local development more convenient so you don't have to rebuild the image every time you make a change. But we don't want this in actions-services.yml since it's meant to test the final image.
forevermatt
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ssp-idp3.local,ssp-sp2.local,ssp-sp3.local,dynamo, andinit-dynamofor test and development.Changed
Removed
Note: the first commit is mostly just copied files, and the remainder are the changes made to those files.