Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly include the silauth module #196

Merged
merged 19 commits into from
May 18, 2024
Merged

directly include the silauth module #196

merged 19 commits into from
May 18, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented May 14, 2024

Added

Changed

  • Changed the namespace on the silauth module source to adhere to SimpleSAMLphp recommendations.

--

Note: the first commit is mostly just copied files, and the remainder are the changes made to those files.

@briskt briskt requested a review from a team May 14, 2024 09:32
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

As a side note, it looks like the action-services.yml and docker-compose.yml are getting pretty long. If they're essentially identical, I'm fine with us working towards combining them. Just my 2 cents (since I was previously the one resistant to that idea).

@jason-jackson
Copy link
Contributor

Approved.

As a side note, it looks like the action-services.yml and docker-compose.yml are getting pretty long. If they're essentially identical, I'm fine with us working towards combining them. Just my 2 cents (since I was previously the one resistant to that idea).

I think if we combine them we need to still handle getting the environment variables. We could do this by setting the test variables in the local.env.dist file or making a test.env file and renaming whichever file we use in the GH action

@briskt
Copy link
Contributor Author

briskt commented May 15, 2024

Approved.

As a side note, it looks like the action-services.yml and docker-compose.yml are getting pretty long. If they're essentially identical, I'm fine with us working towards combining them. Just my 2 cents (since I was previously the one resistant to that idea).

Thanks for that comment. I think it may be warranted as well, once higher-priority work has been done.

Base automatically changed from feature/mfa-module to develop May 18, 2024 02:49
@briskt briskt merged commit cc8413d into develop May 18, 2024
3 checks passed
@briskt briskt deleted the feature/silauth-module branch May 18, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants