-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directly include the silauth module #196
Conversation
as recommended by SimpleSAMLphp documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
As a side note, it looks like the action-services.yml and docker-compose.yml are getting pretty long. If they're essentially identical, I'm fine with us working towards combining them. Just my 2 cents (since I was previously the one resistant to that idea).
I think if we combine them we need to still handle getting the environment variables. We could do this by setting the test variables in the local.env.dist file or making a test.env file and renaming whichever file we use in the GH action |
Thanks for that comment. I think it may be warranted as well, once higher-priority work has been done. |
Added
broker
,brokerDb
, anddb
to help with testing.Changed
--
Note: the first commit is mostly just copied files, and the remainder are the changes made to those files.