directly include the mfa module

[briskt]

Added

• Copied all pertinent code, configuration, and tests from silinternational/simplesamlphp-module-mfa.
• Added a new container pwmanager to help with testing.

Removed

• Removed empty placeholder test scenarios.

Changed

• Changed the namespace on the Assert, LoggerFactory and LoginBrowser classes to avoid a custom autoload.

--

Note: the first commit is mostly just copied files, and the remainder are the changes made to those files.

[forevermatt]

Thanks for doing this, @briskt. It looks like it was a fair bit of work to merge this in. 👍

[briskt]

Thanks for doing this, @briskt. It looks like it was a fair bit of work to merge this in. 👍

It certainly was challenging, especially the part about changing the user agent. And dealing with PHP library versions. Just makes me appreciate Go all the more. :)

[forevermatt]

If you want to keep the class paths shorter, I think we've sometimes/often been using Sil\ as the root of our class namespaces, rather than SilInternational\. Just a option. As long as what's here matches the namespace line in the files under "features/", I think it will work just fine (but you probably know better than I do whether that's correct).

[briskt]

If you want to keep the class paths shorter, I think we've sometimes/often been using Sil\ as the root of our class namespaces, rather than SilInternational\. Just a option. As long as what's here matches the namespace line in the files under "features/", I think it will work just fine (but you probably know better than I do whether that's correct).

I was going for a direct match between the repo name and the namespace, but consistency is often better than "correctness". It's likely a bad assumption that a namespace should match the repository name. I'll change it to "Sil".