allow null in typehint

silinternational · Jun 9, 2024 · 2c9a87d · 2c9a87d
1 parent 0a1cdfd
commit 2c9a87d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/silauth/lib/Auth/Source/auth/Authenticator.php b/modules/silauth/lib/Auth/Source/auth/Authenticator.php
@@ -274,7 +274,7 @@ protected function isBlockedByRateLimit(string $username, array $ipAddresses): b
                FailedLoginIpAddress::isRateLimitBlockingAnyOfThese($ipAddresses);
     }
 
-    public static function isCaptchaRequired(string $username, array $ipAddresses): bool
+    public static function isCaptchaRequired(?string $username, array $ipAddresses): bool
     {
         return FailedLoginUsername::isCaptchaRequiredFor($username) ||
                FailedLoginIpAddress::isCaptchaRequiredForAnyOfThese($ipAddresses);

diff --git a/modules/silauth/lib/Auth/Source/models/FailedLoginUsername.php b/modules/silauth/lib/Auth/Source/models/FailedLoginUsername.php
@@ -108,7 +108,7 @@ public static function isRateLimitBlocking(string $username): bool
         return ($secondsUntilUnblocked > 0);
     }
 
-    public static function isCaptchaRequiredFor(string $username): bool
+    public static function isCaptchaRequiredFor(?string $username): bool
     {
         if (empty($username)) {
             return false;