Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use aws_region data source instead of the variable #241

Merged
merged 2 commits into from
Feb 15, 2024
Merged

use aws_region data source instead of the variable #241

merged 2 commits into from
Feb 15, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Feb 13, 2024

Changed

  • Added a default value to aws_region to make it not required.
  • Use the aws_region data source in place of the aws_region variable.

Added

  • Added local identifier aws_region for simplicity.
  • Added local identifier aws_account for future use.

@briskt briskt requested a review from a team February 13, 2024 21:23
forevermatt
forevermatt approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍

terraform/031-email-service/vars.tf Outdated Show resolved Hide resolved
@briskt briskt merged commit 72dcd31 into develop Feb 15, 2024
2 checks passed
@briskt briskt deleted the feature/remove-var-aws_region branch February 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @forevermatt