Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDP-1266, part 3:] Deprecate ID Broker's use of Google Analytics #388

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[IDP-1266, part 3:] Deprecate ID Broker's use of Google Analytics #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ The API is described by [api.raml](api.raml), and an auto-generated [api.html](a
* `./vendor/bin/behat features/authentication.feature`
* `./vendor/bin/behat features/authentication.feature:298`

## Google Analytics Calls
## Google Analytics Calls - DEPRECATED
Calls are made to Google Analytics regarding users' mfas and whether a password has been pwned.

If you want to have an indication that those calls are likely to succeed, run
Expand Down
5 changes: 5 additions & 0 deletions application/console/controllers/CronController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ public function actionGoogleAnalytics()
{
$eventCategory = 'mfa-usage';

\Yii::warning(
'Reporting ID Broker metrics to Google Analytics is deprecated and '
. 'will be removed in a future release.'
);

$gaEvents = [
'active_users' => User::find()->where(['active' => 'yes'])->count(),
'active_users_with_require_mfa' => User::countUsersWithRequireMfa(),
Expand Down
4 changes: 4 additions & 0 deletions application/console/controllers/GaController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ class GaController extends Controller
*/
public function actionRegister_event()
{
\Yii::warning(
'Sending ID Broker data to Google Analytics is deprecated and will '
. 'be removed in a future release.'
);

list($gaService, $gaRequest) = Utils::GoogleAnalyticsServiceAndRequest("cron");
if ($gaService === null) {
Expand Down