Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix external-groups prefixes with ext- #365

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Prefix external-groups prefixes with ext- #365

merged 3 commits into from
Sep 11, 2024

Conversation

forevermatt
Copy link
Contributor

IDP-1188 Prefix all external groups synced into ID Broker with "ext-"

Fixed

  • Require external-groups app-prefixes to start with "ext-"
  • Improve error message for test step confirming there was a sync error

Feature PR Checklist

  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

@forevermatt forevermatt requested review from a team, briskt, mtompset and jason-jackson and removed request for a team September 10, 2024 19:55
@forevermatt forevermatt merged commit 56f53db into develop Sep 11, 2024
2 checks passed
@forevermatt forevermatt deleted the feature/IDP-1188-prefix-external-groups-prefixes-with-ext branch September 11, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset Awaiting requested review from mtompset mtompset was automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson was automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @briskt