Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getVerifiedMfaOptionsCount - get count of all WebAuthns #332

Merged
merged 7 commits into from
Apr 15, 2024
Merged

fix getVerifiedMfaOptionsCount - get count of all WebAuthns #332

merged 7 commits into from
Apr 15, 2024

Conversation

jason-jackson
Copy link
Contributor

@jason-jackson jason-jackson commented Apr 5, 2024 •
edited by briskt
Loading

Changed

  • Fix getVerifiedMfaOptionsCount to get count of all WebAuthns

https://itse.youtrack.cloud/issue/IDP-767

Feature PR Checklist

  • Documentation (README, local.env.dist, etc.)
  • Unit tests created or updated
  • Run make composershow
  • Run make psr2

@jason-jackson jason-jackson marked this pull request as ready for review April 15, 2024 16:15
@jason-jackson jason-jackson requested a review from a team April 15, 2024 16:15
briskt
briskt reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the PSR2 check failed, which prevented the unit test step from running. None of the PR checklist boxes are ticked either.
Code looks good, though.

application/features/bootstrap/EmailContext.php Outdated Show resolved Hide resolved
application/features/email.feature Show resolved Hide resolved
@jason-jackson jason-jackson merged commit 7584026 into develop Apr 15, 2024
2 checks passed
@jason-jackson jason-jackson deleted the feature/fix-user-webauthn-count branch April 15, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-jackson @briskt