Merge pull request #388 from silinternational/feature/IDP-1266-part-3…

…-deprecate-google-analytics-metrics

[IDP-1266, part 3:] Deprecate ID Broker's use of Google Analytics

README.md

@@ -66,7 +66,7 @@ The API is described by [api.raml](api.raml), and an auto-generated [api.html](a
    * `./vendor/bin/behat features/authentication.feature`
    * `./vendor/bin/behat features/authentication.feature:298`
 
-## Google Analytics Calls
+## Google Analytics Calls - DEPRECATED
 Calls are made to Google Analytics regarding users' mfas and whether a password has been pwned.
 
 If you want to have an indication that those calls are likely to succeed, run 

application/console/controllers/CronController.php

@@ -50,6 +50,11 @@ public function actionGoogleAnalytics()
     {
         $eventCategory = 'mfa-usage';
 
+        \Yii::warning(
+            'Reporting ID Broker metrics to Google Analytics is deprecated and '
+            . 'will be removed in a future release.'
+        );
+
         $gaEvents = [
             'active_users' => User::find()->where(['active' => 'yes'])->count(),
             'active_users_with_require_mfa' => User::countUsersWithRequireMfa(),

application/console/controllers/GaController.php

@@ -15,6 +15,10 @@ class GaController extends Controller
      */
     public function actionRegister_event()
     {
+        \Yii::warning(
+            'Sending ID Broker data to Google Analytics is deprecated and will '
+            . 'be removed in a future release.'
+        );
 
         list($gaService, $gaRequest) = Utils::GoogleAnalyticsServiceAndRequest("cron");
         if ($gaService === null) {