for mfa verification don't require validation for updating last login

silinternational · Sep 11, 2024 · 2deed4c · 2deed4c
1 parent a5bf389
commit 2deed4c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/application/features/bootstrap/MfaContext.php b/application/features/bootstrap/MfaContext.php
@@ -3,7 +3,6 @@
 namespace Sil\SilIdBroker\Behat\Context;
 
 use Behat\Gherkin\Node\TableNode;
-use common\models\EmailLog;
 use common\models\Mfa;
 use common\models\MfaBackupcode;
 use common\models\MfaWebauthn;

diff --git a/application/frontend/controllers/MfaController.php b/application/frontend/controllers/MfaController.php
@@ -63,7 +63,7 @@ public function actionCreate()
      * @throws TooManyRequestsHttpException
      * @return null
      */
-    public function actionVerify(int $id, string $type = "")
+    public function actionVerify(int $id, string $type = ""): Mfa
     {
         $req = \Yii::$app->request;
         $value = $req->getBodyParam('value');
@@ -116,7 +116,7 @@ public function actionVerify(int $id, string $type = "")
         }
         $mfa->loadData($rpOrigin);
         $user->last_login_utc = MySqlDateTime::now();
-        if (!$user->save()) {
+        if (!$user->save(false)) {
             \Yii::error([
                 'action' => 'save last_login_utc for user after mfa verification',
                 'status' => 'error',