Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable IPv6 and remove public IPv4 from ALB #55

Merged
merged 1 commit into from
Dec 3, 2024
Merged

enable IPv6 and remove public IPv4 from ALB #55

merged 1 commit into from
Dec 3, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Dec 2, 2024

Added

  • Add IPv6 to the VPC and ALB, removing the public IPv4 address(es) from the ALB

@briskt briskt requested a review from a team as a code owner December 2, 2024 07:50
@briskt briskt requested review from forevermatt, jason-jackson, hobbitronics and Praveenraj-K and removed request for a team December 2, 2024 07:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

forevermatt
forevermatt approved these changes Dec 2, 2024
View reviewed changes
Copy link

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was a simpler diff than I expected. 👍

@briskt briskt merged commit ba5f6e9 into main Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/tf-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/tf-devs

@Praveenraj-K Praveenraj-K Awaiting requested review from Praveenraj-K Praveenraj-K is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @forevermatt