-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.8.0: Add query filtering on role to members.listMembers #96
Conversation
Add some query logic for roles into members.listMembers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is public and this change could break it for others, I think we shouldn't assume even if it is easier to code.
Granted, no one else seems to be using this, at least according to Github stats.
Implement even more clear roles extraction
Address a sonar issue
Address another sonar issue
Address some more sonar annoyances
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why the query separator is a space character, but other than that it looks fine. By not supporting query parameters other than roles
, you risk having to rewrite this code another time in the future when you're not as fresh on its inner workings. Having said that, I appreciate not wanting to invest much time in a mock.
The separator is a space because ... shoot can't find the query language page.. it has ANDs and ORs and brackets. |
"To search multiple fields in a query, add each search clause, separated by a space. The operation is an implicit AND." (https://developers.google.com/admin-sdk/directory/v1/guides/search-users) -- same for groups, members, and customers. |
Also, I code what I need. Next release will be batching. |
Add