Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.8.0: Add query filtering on role to members.listMembers #96

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

mtompset
Copy link
Contributor

Add

  • query filtering on role to members.listMembers

@mtompset mtompset requested a review from a team June 18, 2024 16:20
@mtompset mtompset self-assigned this Jun 18, 2024
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is public and this change could break it for others, I think we shouldn't assume even if it is easier to code.

Granted, no one else seems to be using this, at least according to Github stats.

SilMock/Google/Service/Directory/Resource/Members.php Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the query separator is a space character, but other than that it looks fine. By not supporting query parameters other than roles, you risk having to rewrite this code another time in the future when you're not as fresh on its inner workings. Having said that, I appreciate not wanting to invest much time in a mock.

@mtompset
Copy link
Contributor Author

The separator is a space because ... shoot can't find the query language page.. it has ANDs and ORs and brackets.

@mtompset
Copy link
Contributor Author

"To search multiple fields in a query, add each search clause, separated by a space. The operation is an implicit AND." (https://developers.google.com/admin-sdk/directory/v1/guides/search-users) -- same for groups, members, and customers.

@mtompset
Copy link
Contributor Author

Also, I code what I need. Next release will be batching.

@mtompset mtompset merged commit 1b804ee into main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants