Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.13.2: Fix aliases data type in group.get results #120

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Release 2.13.2: Fix aliases data type in group.get results #120

merged 4 commits into from
Dec 11, 2024

Conversation

mtompset
Copy link
Contributor

Fix

  • return array of strings and not Alias objects for group.get's aliases property

@mtompset mtompset requested a review from a team December 11, 2024 18:35
@mtompset mtompset self-assigned this Dec 11, 2024
@mtompset mtompset requested review from briskt, forevermatt, jason-jackson and hobbitronics and removed request for a team December 11, 2024 18:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mtompset mtompset merged commit f2698bd into main Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@briskt briskt Awaiting requested review from briskt briskt was automatically assigned from silinternational/php-devs

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt was automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics was automatically assigned from silinternational/php-devs

Assignees

@mtompset mtompset

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtompset @jason-jackson