Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SAML login option (BREAKING CHANGE) #226

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Remove SAML login option (BREAKING CHANGE) #226

merged 4 commits into from
Dec 16, 2024

Conversation

forevermatt
Copy link
Contributor

Removed

  • Remove SAML login option

Fixed

  • Update dependencies
  • Update documentation
  • Specify the available platform version for httpbin docker image (for local development)

@forevermatt forevermatt requested review from a team, briskt, mtompset, jason-jackson and hobbitronics and removed request for a team December 11, 2024 16:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.5% Duplication on New Code

See analysis details on SonarQube Cloud

briskt
briskt approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty thorough. Thanks for taking care of that.

@forevermatt forevermatt merged commit f921409 into develop Dec 16, 2024
3 checks passed
@forevermatt forevermatt deleted the feature/remove-saml-login-option branch December 16, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset Awaiting requested review from mtompset mtompset was automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson was automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics was automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @briskt