-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly display date and time placeholders for DateTimeRangeFilter #112
base: master
Are you sure you want to change the base?
fix: properly display date and time placeholders for DateTimeRangeFilter #112
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 87.45% 86.70% -0.75%
==========================================
Files 9 9
Lines 606 617 +11
==========================================
+ Hits 530 535 +5
- Misses 76 82 +6 ☔ View full report in Codecov by Sentry. |
Look nice! Thanks you! |
closes: #113
Changes:
contrib/admin/widgets.py:AdminSplitDateTime
and made two changes:date_attrs
andtime_attrs
and pass them down to the subwidgets.args
to this init callforms.MultiWidget.__init__(self, widgets)
Status:
Alright, this is working for Django 4.2 and above.
I am currently trying to figure out how to make this work on older versions of django.
Visualize
📸 Before: displays 'date' in the time fields
📸 After: displays 'time' in the time fields