feat(math): Minimal support for accents in MathML and TeX-like commands #2187
+360
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2150
Description
1. So let's first be positive, regarding what this PR brings:
That's not too bad, from a user point of view.
IMHO, we wouldn't fare long without accents, and this is exactly what this PR solves on the surface, leaving room for further improvements (see below).
2. The implementation is slightly more controversial:
This being said, we are closer to the goal, and there's a limit on how much one can do with unfinished and evolving standards. I tend to believe something towards the goal is better than nothing at all, and that the benefits for being able to showcase the above features is greater than waiting for a better implementation that might never come?
What do you think?