Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(math): Minimal support for accents in MathML and TeX-like commands #2187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Dec 3, 2024

Closes #2150

Description

1. So let's first be positive, regarding what this PR brings:

  • MathML accent/accentunder on mover/munder/munderover elements
  • Many top and bottom accents "quite well placed" (no longer floating off the formula): accents, arrows, etc.
  • Proper syntax support for these in TeX-like math syntax
  • TeX-like "variant" limits (varlimsup, varliminf, varprojlim, varinjlim)
  • Horizontal braces, brackets and parentheses, with appropriate TeX math support (over/underbrace, over/underbracket, over/underparen)

That's not too bad, from a user point of view.
IMHO, we wouldn't fare long without accents, and this is exactly what this PR solves on the surface, leaving room for further improvements (see below).

2. The implementation is slightly more controversial:

  • Use of combining vs. non-combining Unicode code points (ideally, we likely need both, with additional conversion tables).
  • Use of horizontal re-scaling when glyph construction is not possible (partly depends on the previous point).
  • Incomplete implementation of MathML Core's layout recommendations. (Well, this was already the case, but it needs to be mentioned: This is not fully closing the gap)
  • Some internal flags introduced as MathML specifications still seems in the flux regarding these topics...

This being said, we are closer to the goal, and there's a limit on how much one can do with unfinished and evolving standards. I tend to believe something towards the goal is better than nothing at all, and that the benefits for being able to showcase the above features is greater than waiting for a better implementation that might never come?

What do you think?

@Omikhleia Omikhleia added bug Software bug issue enhancement Software improvement or feature request labels Dec 3, 2024
@Omikhleia Omikhleia self-assigned this Dec 3, 2024
@Omikhleia Omikhleia requested a review from a team as a code owner December 3, 2024 01:59
@alerque alerque added this to the v0.15.8 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue enhancement Software improvement or feature request
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Math "accents" (for vectors, hats etc.) are not properly supported
2 participants