Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BibTeX types/tags are case-insensitive, etc #1478

Merged
merged 4 commits into from
Jul 15, 2022

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Jul 14, 2022

Closes #1409

Fixes several issues:

  • BibTeX types (@article, @book, etc. and @comment) must be case-insensitive
  • BibTeX tags (labels, i.e. author, editor, year, etc.) must be case-insensitive
  • Other fixes...
    • Some attempts at concatenating tables (options vs. options.key) in error/warning messages
    • A missing error code (UNKNOWN_TYPE)
    • Some minor fixes (e.g. "type" entry in bibtex files need some renaming to avoid overriding the type() function) and minor error check and reporting improvements.

Additionally:

  • Update article and book references to Chicago Citation Style 17th Edition
  • Add fallbacks for other usual BibTeX types (thesis, booklet etc.). It's somewhat hard to map those to the Chicago style in a generic way, so it doesn't claim to be perfect, but at least the output should be reasonable.

This is slightly better than what we had, anyway.

@Omikhleia Omikhleia force-pushed the 1409-bibtex-broken branch from de7d5ec to bd47426 Compare July 14, 2022 10:55
@alerque alerque marked this pull request as draft July 14, 2022 12:57
@Omikhleia
Copy link
Member Author

I am removing my "WIP" from the PR status - As far as I am concerned, I think this is minimally sufficient to address the original issue and get back to a "working" state on this experimental package.

Needed steps to move forward out of "draft" status:

  • Review, obviously...
  • I added a test (tests/bibtex.sil) but didn't push the expected result: For some reason, my SILE 0.13.2 docker uses Gentium v7 while our tests currently expect Gentium v5. I would appreciate if someone could generate the expectations and check them.

Could be an occasion to check my mappings are indeed decent enough, I have seldom used BibTeX ^^

image

@Omikhleia Omikhleia changed the title WIP: BibTeX types/tags are case-insensitive, etc BibTeX types/tags are case-insensitive, etc Jul 15, 2022
@alerque
Copy link
Member

alerque commented Jul 15, 2022

Thanks for working on this. I'm considering cutting a v0.13.3 release from a patch branch because my work on v0.14.0 is quite extensive and testing it might take a little bit yet. Should this go in that?

@alerque
Copy link
Member

alerque commented Jul 15, 2022

For some reason, my SILE 0.13.2 docker uses Gentium v7 while our tests currently expect Gentium v5.

The Docker images are built with Arch Linux, which currently packages Gentium 6.101. Since that was built before the v0.13.2 release I would expect that to be in the Docker image. But at the end of the day it shouldn't matter what is built into Docker because our test system doesn't use any system fonts.

The test system uses a hard coded list of fonts with direct download rules to get the exact versions we want, then special invocations that exclude fontconfig finding system fonts and only using the test suite list. When you update expectations you should be using the same FONTCONFIG setup as the tests use, which can be done with make update_expecteds, even granularly with make update_expecteds TESTSRCS=tests/specifictest.sil or if you know the name of the output you want, just make tests/specifictest.expected.

I would appreciate if someone could generate the expectations and check them.

Sure, glad to. Also glad to see this package getting some tests, they have been sorely lacking to date!

@Omikhleia
Copy link
Member Author

I'm considering cutting a v0.13.3 release from a patch branch because my work on v0.14.0 is quite extensive and testing it might take a little bit yet. Should this go in that?

I'm a bit lost in the release lifecycle, honestly (and the quick pace of some updates). Would you ask, I'd say:

  • Fit in a 0.13.x
  • Fit in a 0.14.0
    • everything we have as breaking PRs or PRs still in progress / needing changes.
    • that would include some things marked as 0.14.x currently, but there's far too many things in that milestone (incl. things which haven't been started at all yet, that were moved from milestones to milestones, etc. We are perhaps running too many marathons, there!).
    • That 0.14 could occur in September or even later (= 3 months or so after 0.13.0) so as to leave some time for testing/reviews and possibly fit more things (e.g. when Add inline-escaping in SIL-language #1347 makes it to master, maybe we can add some of the easily-reachable converters e.g. such as dot -- further to my comment in Pikchr integration #1434 I haved added that to my own repo and markdown converter -- and prepare the way it could be generalized)

@alerque alerque added this to the v0.13.3 milestone Jul 15, 2022
@alerque alerque marked this pull request as ready for review July 15, 2022 11:59
@alerque alerque force-pushed the 1409-bibtex-broken branch from ac0e850 to bcf6bb3 Compare July 15, 2022 12:58
@alerque alerque merged commit e60e01d into sile-typesetter:master Jul 15, 2022
@Omikhleia Omikhleia deleted the 1409-bibtex-broken branch April 10, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bibtex package errors on Jabref metadata
2 participants