Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature on Envelope #1211

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Add signature on Envelope #1211

merged 3 commits into from
Nov 13, 2024

Conversation

DarkaMaul
Copy link
Contributor

Summary

  • Add signature on the Envelope class.
  • Enforce invariants on the Envelope construction

Release Note

Changed

  • Added signature field on the Envelope class

Needed by #1206

@DarkaMaul DarkaMaul mentioned this pull request Nov 13, 2024
Merged
@DarkaMaul
Fix linter.
a090bc7 
Signed-off-by: Alexis <[email protected]>
@woodruffw
Copy link
Member

/gcbrun

woodruffw
woodruffw previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DarkaMaul! Mind updating the CHANGELOG as well to document the new Envelope.signature API?

@woodruffw
Copy link
Member

/gcbrun

@woodruffw woodruffw merged commit 9e371d8 into sigstore:main Nov 13, 2024
23 checks passed
@woodruffw woodruffw deleted the dm/dsse-signature branch November 13, 2024 16:58
@woodruffw
Copy link
Member

Thanks @DarkaMaul, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkaMaul @woodruffw